Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 23447022: ninja windows: VS2013 improvements (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com, zturner
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

ninja windows: VS2013 improvements - Use vs2013 x64->x86 cross compiler if available - Add /FS compiler flag which maintains previous version PDB behavior. R=thakis@chromium.org BUG=chromium:288948 Committed: https://code.google.com/p/gyp/source/detail?r=1725

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pylib/gyp/MSVSVersion.py View 1 chunk +7 lines, -0 lines 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years, 3 months ago (2013-09-12 16:52:19 UTC) #1
Nico
lgtm https://codereview.chromium.org/23447022/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/23447022/diff/1/pylib/gyp/msvs_emulation.py#newcode365 pylib/gyp/msvs_emulation.py:365: # New flag required in 2013 to maintain ...
7 years, 3 months ago (2013-09-12 17:23:21 UTC) #2
scottmg
On 2013/09/12 17:23:21, Nico wrote: > lgtm > > https://codereview.chromium.org/23447022/diff/1/pylib/gyp/msvs_emulation.py > File pylib/gyp/msvs_emulation.py (right): > ...
7 years, 3 months ago (2013-09-12 17:29:10 UTC) #3
scottmg
7 years, 3 months ago (2013-09-12 18:35:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1725.

Powered by Google App Engine
This is Rietveld 408576698