Add toSVGRootInlineBox(), and use it as much as we can

Add toSVGRootInlineBox(), and use it as much as we can

It has type checking assertions, and helps to detect wrong type casting.
This cl removes unnecessary local variable as well.

BUG=N/A

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157733

[gyuyoung-inactive, 2013-09-12 13:52:15]

Add tkent.

[tkent, 2013-09-12 22:45:13]

https://codereview.chromium.org/23447021/diff/1/Source/core/rendering/RenderB...
File Source/core/rendering/RenderBlockLineLayout.cpp (left):

https://codereview.chromium.org/23447021/diff/1/Source/core/rendering/RenderB...
Source/core/rendering/RenderBlockLineLayout.cpp:1448: bool isSVGRootInlineBox =
lineBox->isSVGRootInlineBox();
You don't need to remove this local variable.  isSVGRootInlineBox() is a virtual
function, and calling it requires some cost though it's very small.

[gyuyoung-inactive, 2013-09-13 01:45:24]

On 2013/09/12 22:45:13, tkent wrote:
>
https://codereview.chromium.org/23447021/diff/1/Source/core/rendering/RenderB...
> File Source/core/rendering/RenderBlockLineLayout.cpp (left):
> 
>
https://codereview.chromium.org/23447021/diff/1/Source/core/rendering/RenderB...
> Source/core/rendering/RenderBlockLineLayout.cpp:1448: bool isSVGRootInlineBox
=
> lineBox->isSVGRootInlineBox();
> You don't need to remove this local variable.  isSVGRootInlineBox() is a
virtual
> function, and calling it requires some cost though it's very small.

I prefer not to use local variables as much as possible. But, I don't object to
keep it because of your comment is reasonable as well. Thx.

[tkent, 2013-09-13 01:49:00]

lgtm

[commit-bot: I haz the power, 2013-09-13 01:49:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23447021/4001

[commit-bot: I haz the power, 2013-09-13 02:55:51]

Change committed as 157733