Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2344683003: Reland: ImageCapture: Connect takePhoto() VideoCaptureDeviceTest (Closed)

Created:
4 years, 3 months ago by mcasas
Modified:
4 years, 3 months ago
Reviewers:
emircan, chfremer
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: ImageCapture: Connect takePhoto() VideoCaptureDeviceTest The original CL got reverted due to failing on a Lollipop bot. This CL avoids Lollipops while investigations continue. Original CL description ------------------------------------------------ This CL enables VideoCaptureDeviceTest.TakePhoto for Android. (Note that, due to other circumstances, it'll only be enabled for devices implementing the Camera2 API in non-legacy mode). The only modification is that Android creates JPEGs with APP1 JFIF header, because it includes EXIF information. BUG=518807, 626857 TBR=emircan@chromium.org since the addec change is trivial. Committed: https://crrev.com/de719226369c798fcb0a8afc0c02d3cf1c4c367e Cr-Commit-Position: refs/heads/master@{#419039}

Patch Set 1 : https://codereview.chromium.org/2340573002/ #

Patch Set 2 : Don't run VideoCaptureDeviceTest.TakePhoto in Lollipop devices or earlier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M media/capture/video/video_capture_device_unittest.cc View 1 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mcasas
emircan@/chfremer@ RS plz
4 years, 3 months ago (2016-09-15 17:58:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344683003/20001
4 years, 3 months ago (2016-09-15 20:39:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/227275)
4 years, 3 months ago (2016-09-15 21:03:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344683003/20001
4 years, 3 months ago (2016-09-15 23:42:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 23:49:08 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 23:50:25 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de719226369c798fcb0a8afc0c02d3cf1c4c367e
Cr-Commit-Position: refs/heads/master@{#419039}

Powered by Google App Engine
This is Rietveld 408576698