Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc

Issue 2344673002: Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
diff --git a/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
index 4c6d8c7bb03e41eb49d534816cc920fa760a944a..fa5eaf8c3a152099ef8dcc46a22b5ba9f0f4b37a 100644
--- a/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
+++ b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
@@ -149,19 +149,13 @@ TEST(DesktopSessionDurationTrackerTest, TestAudioEvent) {
histogram_tester.ExpectTotalCount("Session.TotalDuration", 1);
}
-// Flaky on Mac Debug. See http://crbug.com/646758
-#if defined(OS_MACOSX)
-#define MAYBE_TestTimeoutDiscount DISABLED_TestTimeoutDiscount
-#else
-#define MAYBE_TestTimeoutDiscount TestTimeoutDiscount
-#endif
-TEST(DesktopEngagementServiceTest, MAYBE_TestTimeoutDiscount) {
+TEST(DesktopSessionDurationTrackerTest, TestTimeoutDiscount) {
base::MessageLoop loop(base::MessageLoop::TYPE_DEFAULT);
base::HistogramTester histogram_tester;
MockDesktopSessionDurationTracker instance;
- int inactivity_interval = 2;
- instance.SetInactivityTimeoutForTesting(inactivity_interval);
+ int inactivity_interval_seconds = 2;
+ instance.SetInactivityTimeoutForTesting(inactivity_interval_seconds);
instance.OnVisibilityChanged(true);
base::TimeTicks before_session_start = base::TimeTicks::Now();
@@ -175,10 +169,11 @@ TEST(DesktopEngagementServiceTest, MAYBE_TestTimeoutDiscount) {
base::TimeTicks after_session_end = base::TimeTicks::Now();
histogram_tester.ExpectTotalCount("Session.TotalDuration", 1);
- // The recorded value should be shorter than the specified inactivity
- // interval.
base::Bucket bucket =
histogram_tester.GetAllSamples("Session.TotalDuration")[0];
- EXPECT_LE(bucket.min + inactivity_interval,
- (after_session_end - before_session_start).InSeconds());
+ int max_expected_value =
+ (after_session_end - before_session_start -
+ base::TimeDelta::FromSeconds(inactivity_interval_seconds))
+ .InMilliseconds();
+ EXPECT_LE(bucket.min, max_expected_value);
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698