Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538, 646758
Committed: https://crrev.com/68de0eb04f00eed4467bb743eccaec1b92dba132
Cr-Commit-Position: refs/heads/master@{#419000}

[gayane -on leave until 09-2017, 2016-09-14 21:53:45]

Description was changed from

==========
Fix measurment units for DesktopEngagementService unittest

BUG=
==========

to

==========
Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538
==========

[gayane -on leave until 09-2017, 2016-09-14 21:54:13]

gayane@chromium.org changed reviewers:
+ asvitkine@chromium.org

[gayane -on leave until 09-2017, 2016-09-14 21:54:14]

PTAL

[Alexei Svitkine (slow), 2016-09-15 16:40:22]

(You may also need to rebase on top of the class rename CL.)

https://codereview.chromium.org/2344673002/diff/1/chrome/browser/metrics/desk...
File
chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc
(right):

https://codereview.chromium.org/2344673002/diff/1/chrome/browser/metrics/desk...
chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc:175:
base::TimeDelta::FromSeconds(inactivity_interval)).ToInternalValue();
If the unit is milliseconds, please convert explicitly to milliseconds rather
than to internal value.

[gayane -on leave until 09-2017, 2016-09-15 18:37:37]

Thanks Alexei. Converted to milliseconds.

https://codereview.chromium.org/2344673002/diff/1/chrome/browser/metrics/desk...
File
chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc
(right):

https://codereview.chromium.org/2344673002/diff/1/chrome/browser/metrics/desk...
chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc:175:
base::TimeDelta::FromSeconds(inactivity_interval)).ToInternalValue();
On 2016/09/15 16:40:22, Alexei Svitkine (very slow) wrote:
> If the unit is milliseconds, please convert explicitly to milliseconds rather
> than to internal value.

Done.

[gayane -on leave until 09-2017, 2016-09-15 18:38:40]

Description was changed from

==========
Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538
==========

to

==========
Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538, 646758
==========

[Alexei Svitkine (slow), 2016-09-15 20:28:14]

lgtm

[gayane -on leave until 09-2017, 2016-09-15 20:59:45]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:00:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:03:37]

Description was changed from

==========
Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538, 646758
==========

to

==========
Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538, 646758
==========

[commit-bot: I haz the power, 2016-09-15 22:03:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 22:05:18]

Description was changed from

==========
Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538, 646758
==========

to

==========
Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538, 646758

Committed: https://crrev.com/68de0eb04f00eed4467bb743eccaec1b92dba132
Cr-Commit-Position: refs/heads/master@{#419000}
==========

[commit-bot: I haz the power, 2016-09-15 22:05:19]

Patchset 3 (id:??) landed as
https://crrev.com/68de0eb04f00eed4467bb743eccaec1b92dba132
Cr-Commit-Position: refs/heads/master@{#419000}