Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2344653002: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rlp+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some ChromeSyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - launcher_search_provider - hotword_private - i18n - identity - omnibox BUG=634140 Committed: https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28 Cr-Commit-Position: refs/heads/master@{#418733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -142 lines) Patch
M chrome/browser/chromeos/extensions/launcher_search_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/launcher_search_provider.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_api.h View 15 chunks +29 lines, -33 lines 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_api.cc View 6 chunks +71 lines, -60 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.h View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
lazyboy, mind taking a look?
4 years, 3 months ago (2016-09-14 22:56:50 UTC) #6
lazyboy
lgtm.
4 years, 3 months ago (2016-09-14 23:18:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344653002/1
4 years, 3 months ago (2016-09-15 00:10:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 00:54:58 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 00:58:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28
Cr-Commit-Position: refs/heads/master@{#418733}

Powered by Google App Engine
This is Rietveld 408576698