Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 2344633005: Add histograms for parseAuthorStyleSheet and updateStyle (Closed)

Created:
4 years, 3 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
Reviewers:
esprehn, Steven Holte
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histograms for parseAuthorStyleSheet and updateStyle BUG=642722 Committed: https://crrev.com/78f6cc334b7c0231a6a9a6fe6de9f7183c5796ce Cr-Commit-Position: refs/heads/master@{#421659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Charlie Harrison
esprehn@, these are two places where lazy parsing CSS properties will affect performance. Are there ...
4 years, 3 months ago (2016-09-15 18:57:52 UTC) #4
esprehn
This lgtm, note though that the bigger updateStyleAndLayoutTree function is the full process of "style", ...
4 years, 2 months ago (2016-09-28 03:49:36 UTC) #7
Charlie Harrison
Thanks, I hoped instrumenting just update_style would give us less noisy data. +holte for histograms.xml
4 years, 2 months ago (2016-09-28 04:35:52 UTC) #9
Steven Holte
lgtm
4 years, 2 months ago (2016-09-28 19:28:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344633005/1
4 years, 2 months ago (2016-09-28 20:37:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 22:19:49 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 22:22:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78f6cc334b7c0231a6a9a6fe6de9f7183c5796ce
Cr-Commit-Position: refs/heads/master@{#421659}

Powered by Google App Engine
This is Rietveld 408576698