Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 234463003: Avoid using cross RenderView selection rendering (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2014-04-14T01:01:05 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/editing/undo/crash-redo-with-iframes-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index f2f39734097e4d0f606ca191c040efcde9d653d5..c592a8c6008170e3f0a454d3e52de08daf5cfb20 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -1586,7 +1586,8 @@ void FrameSelection::updateAppearance()
if (startPos.isNotNull() && endPos.isNotNull() && selection.visibleStart() != selection.visibleEnd()) {
RenderObject* startRenderer = startPos.deprecatedNode()->renderer();
RenderObject* endRenderer = endPos.deprecatedNode()->renderer();
- view->setSelection(startRenderer, startPos.deprecatedEditingOffset(), endRenderer, endPos.deprecatedEditingOffset());
+ if (startRenderer->view() == view && endRenderer->view() == view)
Yuta Kitamura 2014/04/14 06:23:40 This line would probably deserve some comments bec
yosin_UTC9 2014/04/14 08:03:56 Done.
+ view->setSelection(startRenderer, startPos.deprecatedEditingOffset(), endRenderer, endPos.deprecatedEditingOffset());
}
}
« no previous file with comments | « LayoutTests/editing/undo/crash-redo-with-iframes-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698