Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 234463003: Avoid using cross RenderView selection rendering (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/editing/execCommand/crash-redo-with-iframes-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index f2f39734097e4d0f606ca191c040efcde9d653d5..1607c89756665d87288c7331d17a1968871cad75 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -229,8 +229,8 @@ void FrameSelection::setSelection(const VisibleSelection& newSelection, SetSelec
// <http://bugs.webkit.org/show_bug.cgi?id=23464>: Infinite recursion at FrameSelection::setSelection
// if document->frame() == m_frame we can get into an infinite loop
- if (s.base().anchorNode()) {
- Document& document = *s.base().document();
+ if (s.start().anchorNode()) {
Yuta Kitamura 2014/04/11 08:59:22 As far as I know, the relationship among base, ext
+ Document& document = *s.start().document();
if (document.frame() && document.frame() != m_frame && document != m_frame->document()) {
RefPtr<LocalFrame> guard = document.frame();
document.frame()->selection().setSelection(s, options, align, granularity);
« no previous file with comments | « LayoutTests/editing/execCommand/crash-redo-with-iframes-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698