Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2344563003: Revert "Roll isolate go to binaries as generated by infra @ 6f3db5a82956." (Closed)

Created:
4 years, 3 months ago by M-A Ruel
Modified:
4 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll isolate go to binaries as generated by infra @ 6f3db5a82956." This reverts commit a7ce77dda519428ce58039382485c7cd0cc05ab7. Monitoring tells us severely regressed isolate performance. TBR=jam@chromium.org BUG=644410 Committed: https://crrev.com/07ac77f394925721fbeee21d94644a754fcc6025 Cr-Commit-Position: refs/heads/master@{#418639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/luci-go/linux64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/mac64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/win64/isolate.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
M-A Ruel
4 years, 3 months ago (2016-09-14 18:41:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344563003/1
4 years, 3 months ago (2016-09-14 18:42:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 19:36:00 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 19:39:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07ac77f394925721fbeee21d94644a754fcc6025
Cr-Commit-Position: refs/heads/master@{#418639}

Powered by Google App Engine
This is Rietveld 408576698