Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2344553002: 565 is not this important. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

565 is not this important. Reduce its testing and perfing to just the fast Linux bots, and remove it from the default set of dm/nanobench configs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002 Committed: https://skia.googlesource.com/skia/+/896ddb706d2eb9d8ebad61f767de058f7f0708a0

Patch Set 1 #

Patch Set 2 : still an option #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -55 lines) Patch
M infra/bots/recipes/swarm_perf.py View 1 chunk +3 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Release.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Release.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Release.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN.json View 2 chunks +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug.json View 2 chunks +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 2 chunks +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/recipe_with_gerrit_patch.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_test.py View 2 chunks +2 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-AndroidOne-GPU-Mali400MP2-Arm7-Release.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Release.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +0 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/adb_in_path.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skimage.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skps.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_svgs.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SVG_VERSION_device.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/recipe_with_gerrit_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
mtklein_C
4 years, 3 months ago (2016-09-14 15:53:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344553002/1
4 years, 3 months ago (2016-09-14 15:53:42 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-14 15:53:45 UTC) #7
reed1
lgtm
4 years, 3 months ago (2016-09-14 17:26:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344553002/20001
4 years, 3 months ago (2016-09-14 17:31:51 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 17:33:16 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/896ddb706d2eb9d8ebad61f767de058f7f0708a0

Powered by Google App Engine
This is Rietveld 408576698