Remove SVG1.1 kerning property

Remove SVG1.1 kerning property

This SVG1.1[1] property has been removed from SVG2[2] and can be removed.

[1] http://www.w3.org/TR/SVG11/single-page.html#text-KerningProperty
[2] https://svgwg.org/svg2-draft/single-page.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171393

[pdr., 2014-04-11 00:25:21]

https://codereview.chromium.org/234453002/diff/1/Source/core/rendering/style/...
File Source/core/rendering/style/SVGRenderStyleDefs.h (left):

https://codereview.chromium.org/234453002/diff/1/Source/core/rendering/style/...
Source/core/rendering/style/SVGRenderStyleDefs.h:185: class StyleTextData :
public RefCounted<StyleTextData> {
This class was used to just store kerning. Interesting.

https://codereview.chromium.org/234453002/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGTextLayoutEngine.cpp (right):

https://codereview.chromium.org/234453002/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGTextLayoutEngine.cpp:511: float kerning =
spacingLayout.calculateSVGKerning(m_isVerticalText, visualMetrics.glyph());
SVG Fonts still support a kerning element. This will go away when SVG fonts are
finally removed.

[ojan, 2014-04-11 00:36:20]

This looks to be used on 0.01% of pages on Windows stable and 0.0005% on Android
stable.

You need to send an intent to remove to blink-dev. Please do so and give it a
day or two for people to comment before committing. Otherwise, lgtm.

https://codereview.chromium.org/234453002/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/234453002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:445: // case CSSPropertyKerning: return 391;
You can just delete this now that we number these.

[pdr., 2014-04-11 01:59:53]

On 2014/04/11 00:36:20, ojan wrote:
> This looks to be used on 0.01% of pages on Windows stable and 0.0005% on
Android
> stable.
> 
> You need to send an intent to remove to blink-dev. Please do so and give it a
> day or two for people to comment before committing. Otherwise, lgtm.

Thanks for keeping me honest. Intent sent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eTpyBBumyfs

> 
>
https://codereview.chromium.org/234453002/diff/1/Source/core/frame/UseCounter...
> File Source/core/frame/UseCounter.cpp (right):
> 
>
https://codereview.chromium.org/234453002/diff/1/Source/core/frame/UseCounter...
> Source/core/frame/UseCounter.cpp:445: // case CSSPropertyKerning: return 391;
> You can just delete this now that we number these.

I updated the comment here to follow the ones below it. Probably best to leave
these comments in to discourage folks from reusing entries.

[ojan, 2014-04-11 02:12:34]

>
https://codereview.chromium.org/234453002/diff/1/Source/core/frame/UseCounter...
> > Source/core/frame/UseCounter.cpp:445: // case CSSPropertyKerning: return
391;
> > You can just delete this now that we number these.
> 
> I updated the comment here to follow the ones below it. Probably best to leave
> these comments in to discourage folks from reusing entries.

Meh. I don't think the threat of that is very large. It's very unlikely someone
adding a new property will think to look for an entry in the middle to fill in.

[pdr., 2014-04-12 00:20:41]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-04-12 00:20:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/234453002/40001

[pdr., 2014-04-12 00:26:06]

3x LGTMs from API owners. In we go!

[commit-bot: I haz the power, 2014-04-12 01:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-12 01:20:27]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[pdr., 2014-04-12 01:22:20]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-04-12 01:22:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/234453002/40001

[commit-bot: I haz the power, 2014-04-12 01:55:58]

Change committed as 171393

[pdr., 2014-04-12 23:08:39]

On 2014/04/12 01:55:58, I haz the power (commit-bot) wrote:
> Change committed as 171393

I should have included the bug in the change description. It is crbug.com/362364