Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2344503003: Revert of ImageCapture: Connect takePhoto() VideoCaptureDeviceTest (Closed)

Created:
4 years, 3 months ago by aberent
Modified:
4 years, 3 months ago
Reviewers:
emircan, mcasas, chfremer
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ImageCapture: Connect takePhoto() VideoCaptureDeviceTest (patchset #1 id:1 of https://codereview.chromium.org/2340573002/ ) Reason for revert: Fails on Android L. BUG=646840 Original issue's description: > ImageCapture: Connect takePhoto() VideoCaptureDeviceTest > > This CL enables VideoCaptureDeviceTest.TakePhoto for > Android. (Note that, due to other circumstances, it'll > only be enabled for devices implementing the Camera2 > API in non-legacy mode). > > The only modification is that Android creates JPEGs > with APP1 JFIF header, because it includes EXIF information. > > BUG=518807, 626857 > > Committed: https://crrev.com/a8ae6bfb0e432ee220b641b0e8bb3f4800a7448a > Cr-Commit-Position: refs/heads/master@{#418423} TBR=emircan@chromium.org,chfremer@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518807, 626857 Committed: https://crrev.com/2cedd2f7b2e116a977cb4812e2479733d295b96a Cr-Commit-Position: refs/heads/master@{#418580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/capture/video/video_capture_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aberent
Created Revert of ImageCapture: Connect takePhoto() VideoCaptureDeviceTest
4 years, 3 months ago (2016-09-14 16:21:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344503003/1
4 years, 3 months ago (2016-09-14 16:21:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 16:22:42 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:25:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cedd2f7b2e116a977cb4812e2479733d295b96a
Cr-Commit-Position: refs/heads/master@{#418580}

Powered by Google App Engine
This is Rietveld 408576698