net/proxy/proxy_resolver_v8.cc - Issue 23445021: Remove calls to to-be-deprecated v8::Persistent funcs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_v8.cc

Issue 23445021: Remove calls to to-be-deprecated v8::Persistent funcs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_v8.cc

diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc

index 87f61028039787c81b997e3b3f8736f6d88c0129..0c51d5da3adc00aa22c3bcdb67e3f0f107760a8f 100644

--- a/net/proxy/proxy_resolver_v8.cc

+++ b/net/proxy/proxy_resolver_v8.cc

@@ -342,8 +342,8 @@ class ProxyResolverV8::Context {

~Context() {

v8::Locker locked(isolate_);

- v8_this_.Dispose(isolate_);

- v8_context_.Dispose(isolate_);

+ v8_this_.Dispose();

+ v8_context_.Dispose();

}

JSBindings* js_bindings() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »