Chromium Code Reviews Chromium Code Reviews
Issue 23445013:
Parse media keys for named command in the manifest. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/common/extensions/docs/templates/intros/commands.html |
| diff --git a/chrome/common/extensions/docs/templates/intros/commands.html b/chrome/common/extensions/docs/templates/intros/commands.html |
| index 8720da7f7de6a8745c250dfabc7921228fc33581..f9605070d13f42e2107849b56aa4b9252c5839e9 100644 |
| --- a/chrome/common/extensions/docs/templates/intros/commands.html |
| +++ b/chrome/common/extensions/docs/templates/intros/commands.html |
| @@ -11,11 +11,13 @@ have many commands but only 4 suggested keys can be specified. The user can |
| manually add more shortcuts from the chrome://extensions page.</p> |
| <p>Supported keys: A-Z, 0-9, Comma, Period, Home, End, PageUp, PageDown, Insert, |
| -Delete, Tab and the arrow keys (Up, Down, Left, Right).</p> |
| +Delete, Tab, Arrow keys (Up, Down, Left, Right) and the Media Keys |
| +(MediaNextTrack, MediaPlayPause, MediaPrevTrack, MediaStop).</p> |
| <p>Note: All key combinations must include either Ctrl* or Alt. Combinations |
| that involve Ctrl+Alt are not permitted in order to avoid conflicts with the |
| -AltGr key. Shift can be used in addition to Alt or Ctrl, but is not required.<p> |
| +AltGr key. Shift can be used in addition to Alt or Ctrl, but is not required. |
| +Media keys cannot be used in key combination, just use them singly.<p> |
|
Finnur
2013/08/30 11:39:28
Suggest rewording:
Modifiers (such as Ctrl) can no
zhchbin
2013/08/30 12:00:36
Done.
Hmm...I think we have the ability to detect
|
| <p>* Also note that on Mac 'Ctrl' is automatically converted to 'Command'. If |
| you want 'Ctrl' instead, please specify 'MacCtrl'.</p> |
