chrome/common/extensions/command.h - Issue 23445013: Parse media keys for named command in the manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/command.h

Issue 23445013: Parse media keys for named command in the manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit fix. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/command.h

diff --git a/chrome/common/extensions/command.h b/chrome/common/extensions/command.h

index 77ff28ab1ba773c70941f0d3b9bab4435077fd5a..963d26ba885ffa45440cfa7a6a99ff1ca5e0e5d4 100644

--- a/chrome/common/extensions/command.h

+++ b/chrome/common/extensions/command.h

@@ -34,7 +34,8 @@ class Command {

// Parse a string as an accelerator. If the accelerator is unparsable then

// a generic ui::Accelerator object will be returns (with key_code Unknown).

- static ui::Accelerator StringToAccelerator(const std::string& accelerator);

+ static ui::Accelerator StringToAccelerator(const std::string& accelerator,

+ const std::string& command_name);

// Returns the string representation of an accelerator without localizing the

// shortcut text (like accelerator::GetShortcutText() does).