Mark exception handlers if they have a stacktrace specified. Do not build a stacktrace if the handl…

runtime/vm/object_test.cc

Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc	(revision 26792)
+++ runtime/vm/object_test.cc	(working copy)
@@ -2385,10 +2385,12 @@
   // Add an exception handler table to the code.
   ExceptionHandlers& exception_handlers = ExceptionHandlers::Handle();
   exception_handlers ^= ExceptionHandlers::New(kNumEntries);
-  exception_handlers.SetHandlerInfo(0, -1, 20);
-  exception_handlers.SetHandlerInfo(1, 0, 30);
-  exception_handlers.SetHandlerInfo(2, -1, 40);
-  exception_handlers.SetHandlerInfo(3, 1, 150);
+  const bool kNeedsStacktrace = true;
+  const bool kNeedsNoStacktrace = false;

[hausner, 2013/08/28 16:08:20]

kNoStackTrace ?

[srdjan, 2013/08/28 20:38:29]

Done.

+  exception_handlers.SetHandlerInfo(0, -1, 20, kNeedsStacktrace);
+  exception_handlers.SetHandlerInfo(1, 0, 30, kNeedsStacktrace);
+  exception_handlers.SetHandlerInfo(2, -1, 40, kNeedsNoStacktrace);
+  exception_handlers.SetHandlerInfo(3, 1, 150, kNeedsNoStacktrace);
 
   extern void GenerateIncrement(Assembler* assembler);
   Assembler _assembler_;
@@ -2406,9 +2408,11 @@
   EXPECT_EQ(-1, handlers.OuterTryIndex(0));
   EXPECT_EQ(-1, info.outer_try_index);
   EXPECT_EQ(20, handlers.HandlerPC(0));
+  EXPECT(handlers.NeedsStacktrace(0));
   EXPECT_EQ(20, info.handler_pc);
   EXPECT_EQ(1, handlers.OuterTryIndex(3));
   EXPECT_EQ(150, handlers.HandlerPC(3));
+  EXPECT(!handlers.NeedsStacktrace(3));
 }