Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: runtime/vm/ast.h

Issue 23445012: Mark exception handlers if they have a stacktrace specified. Do not build a stacktrace if the handl… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_descriptors.h » ('j') | runtime/vm/exceptions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/ast.h
===================================================================
--- runtime/vm/ast.h (revision 26815)
+++ runtime/vm/ast.h (working copy)
@@ -1604,14 +1604,16 @@
const LocalVariable* context_var,
const LocalVariable* exception_var,
const LocalVariable* stacktrace_var,
- intptr_t catch_handler_index)
+ intptr_t catch_handler_index,
+ bool needs_stacktrace)
: AstNode(token_pos),
catch_block_(catch_block),
handler_types_(handler_types),
context_var_(*context_var),
exception_var_(*exception_var),
stacktrace_var_(*stacktrace_var),
- catch_handler_index_(catch_handler_index) {
+ catch_handler_index_(catch_handler_index),
+ needs_stacktrace_(needs_stacktrace) {
ASSERT(catch_block_ != NULL);
ASSERT(handler_types.IsZoneHandle());
ASSERT(context_var != NULL);
@@ -1624,6 +1626,7 @@
const LocalVariable& exception_var() const { return exception_var_; }
const LocalVariable& stacktrace_var() const { return stacktrace_var_; }
intptr_t catch_handler_index() const { return catch_handler_index_; }
+ bool needs_stacktrace() const { return needs_stacktrace_; }
virtual void VisitChildren(AstNodeVisitor* visitor) const {
catch_block_->Visit(visitor);
@@ -1638,6 +1641,7 @@
const LocalVariable& exception_var_;
const LocalVariable& stacktrace_var_;
const intptr_t catch_handler_index_;
+ const bool needs_stacktrace_;
DISALLOW_COPY_AND_ASSIGN(CatchClauseNode);
};
« no previous file with comments | « no previous file | runtime/vm/code_descriptors.h » ('j') | runtime/vm/exceptions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698