Chromium Code Reviews| Index: pkg/polymer/lib/src/transform/common.dart |
| diff --git a/pkg/polymer/lib/src/transform/common.dart b/pkg/polymer/lib/src/transform/common.dart |
| index c72e8b1cd92f84552a81a9a625f5535fbdd8c604..d9f1c978a7889ad7d8f240fdead245316e3fe3c2 100644 |
| --- a/pkg/polymer/lib/src/transform/common.dart |
| +++ b/pkg/polymer/lib/src/transform/common.dart |
| @@ -50,7 +50,9 @@ AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) { |
| var uri = Uri.parse(url); |
| var urlBuilder = path.url; |
| if (uri.host != '' || uri.scheme != '' || urlBuilder.isAbsolute(url)) { |
| - logger.error('absolute paths not allowed: "$url"', span); |
| + if (logger != null) { |
|
Jennifer Messerly
2013/08/28 22:25:45
ideally we would always have a logger
Siggi Cherem (dart-lang)
2013/08/28 23:17:06
ok, reverted this change.
|
| + logger.error('absolute paths not allowed: "$url"', span); |
| + } |
| return null; |
| } |
| @@ -59,8 +61,10 @@ AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) { |
| var segments = urlBuilder.split(url); |
| if (segments[0] == 'packages') { |
| if (segments.length < 3) { |
| - logger.error("incomplete packages/ path. It should have at least 3 " |
| - "segments packages/name/path-from-name's-lib-dir", span); |
| + if (logger != null) { |
| + logger.error("incomplete packages/ path. It should have at least 3 " |
| + "segments packages/name/path-from-name's-lib-dir", span); |
| + } |
| return null; |
| } |
| package = segments[1]; |
| @@ -68,8 +72,11 @@ AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) { |
| urlBuilder.joinAll(segments.sublist(2))); |
| } else if (segments[0] == 'assets') { |
| if (segments.length < 3) { |
| - logger.error("incomplete assets/ path. It should have at least 3 " |
| - "segments assets/name/path-from-name's-asset-dir", span); |
| + if (logger != null) { |
| + logger.error("incomplete assets/ path. It should have at least 3 " |
| + "segments assets/name/path-from-name's-asset-dir", span); |
| + } |
| + return null; |
| } |
| package = segments[1]; |
| targetPath = urlBuilder.join('asset', |