Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: pkg/observe/lib/transform.dart

Issue 23445009: Prune the old deploy code. This CL does a few changes: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/polymer/bin/dwc.dart » ('j') | pkg/polymer/lib/component_build.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/observe/lib/transform.dart
diff --git a/pkg/observe/lib/transform.dart b/pkg/observe/lib/transform.dart
index 99cb13b47e4bd797f1bef5b75fb78875ecde9e20..434a949ddcad5773d4e0609be44dde0247d6bd5d 100644
--- a/pkg/observe/lib/transform.dart
+++ b/pkg/observe/lib/transform.dart
@@ -9,12 +9,13 @@
library observe.transform;
import 'dart:async';
-import 'package:path/path.dart' as path;
+
import 'package:analyzer_experimental/src/generated/ast.dart';
import 'package:analyzer_experimental/src/generated/error.dart';
import 'package:analyzer_experimental/src/generated/parser.dart';
import 'package:analyzer_experimental/src/generated/scanner.dart';
import 'package:barback/barback.dart';
+import 'package:path/path.dart' as path;
import 'package:source_maps/refactor.dart';
import 'package:source_maps/span.dart' show SourceFile;
@@ -63,15 +64,7 @@ class ObservableTransformer extends Transformer {
TextEditTransaction _transformCompilationUnit(
String inputCode, SourceFile sourceFile, TransformLogger logger) {
var unit = _parseCompilationUnit(inputCode);
- return transformObservables(unit, sourceFile, inputCode, logger);
-}
-
-// TODO(sigmund): make this private. This is currently public so it can be used
-// by the polymer.dart package which is not yet entirely migrated to use
-// pub-serve and pub-deploy.
-TextEditTransaction transformObservables(CompilationUnit unit,
- SourceFile sourceFile, String content, TransformLogger logger) {
- var code = new TextEditTransaction(content, sourceFile);
+ var code = new TextEditTransaction(inputCode, sourceFile);
for (var directive in unit.directives) {
if (directive is LibraryDirective && _hasObservable(directive)) {
logger.warning('@observable on a library no longer has any effect. '
« no previous file with comments | « no previous file | pkg/polymer/bin/dwc.dart » ('j') | pkg/polymer/lib/component_build.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698