Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2344493002: [gn] Fix no-inline config for V8 (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix no-inline config for V8 This restores the original gyp behavior. Blocks: https://codereview.chromium.org/2334003005 BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/3999fb07885eb54af05f35cd58ef2c4e2734b4d4 Cr-Commit-Position: refs/heads/master@{#39414}

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M BUILD.gn View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M infra/mb/mb_config.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. The "symbolized" config and respective builders were deprecated in chromium, which I intend too. ...
4 years, 3 months ago (2016-09-14 11:05:50 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-14 11:14:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344493002/40001
4 years, 3 months ago (2016-09-14 11:15:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-14 11:18:28 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 11:18:58 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3999fb07885eb54af05f35cd58ef2c4e2734b4d4
Cr-Commit-Position: refs/heads/master@{#39414}

Powered by Google App Engine
This is Rietveld 408576698