Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2951)

Unified Diff: appengine/findit/waterfall/build_failure_analysis.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: reordering imports Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/build_failure_analysis.py
diff --git a/appengine/findit/waterfall/build_failure_analysis.py b/appengine/findit/waterfall/build_failure_analysis.py
index 369d72f10ce74332b86c996b70a9db5e87d3c2a6..14450624e00296cdf407bf0b1123c013f01afd8e 100644
--- a/appengine/findit/waterfall/build_failure_analysis.py
+++ b/appengine/findit/waterfall/build_failure_analysis.py
@@ -6,11 +6,11 @@ from collections import defaultdict
import os
import re
-from common.diff import ChangeType
-from common.git_repository import GitRepository
from common.http_client_appengine import HttpClientAppengine as HttpClient
-from waterfall import waterfall_config
+from lib.gitiles.diff import ChangeType
+from lib.gitiles.gitiles_repository import GitilesRepository
from waterfall.failure_signal import FailureSignal
+from waterfall import waterfall_config
def _IsSameFile(changed_src_file_path, file_path_in_log):
@@ -44,7 +44,7 @@ def _GetGitBlame(repo_info, touched_file_path):
"""
if repo_info:
repo_url = repo_info['repo_url']
- git_repo = GitRepository(repo_url, HttpClient())
+ git_repo = GitilesRepository(repo_url, HttpClient())
revision = repo_info['revision']
return git_repo.GetBlame(touched_file_path, revision)
@@ -442,7 +442,7 @@ def _GetChangedLinesForDependencyRepo(roll, file_path_in_log, line_numbers):
Tests if the same lines mentioned in failure log are changed within
the DEPS roll, if so, return those line numbers.
"""
- roll_repo = GitRepository(roll['repo_url'], HttpClient())
+ roll_repo = GitilesRepository(roll['repo_url'], HttpClient())
old_revision = roll['old_revision']
new_revision = roll['new_revision']
old_change_log = roll_repo.GetChangeLog(old_revision)
@@ -805,4 +805,4 @@ def AnalyzeBuildFailure(
suspected_cls = _ConvertCLFailureMapToList(cl_failure_map)
- return analysis_result, suspected_cls
+ return analysis_result, suspected_cls
« no previous file with comments | « appengine/findit/lib/test/cache_decorator_test.py ('k') | appengine/findit/waterfall/extract_deps_info_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698