Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: appengine/findit/lib/gitiles/gitiles_repository.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: reordering imports Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/lib/gitiles/git_repository.py ('k') | appengine/findit/lib/gitiles/test/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/lib/gitiles/gitiles_repository.py
diff --git a/appengine/findit/common/git_repository.py b/appengine/findit/lib/gitiles/gitiles_repository.py
similarity index 94%
rename from appengine/findit/common/git_repository.py
rename to appengine/findit/lib/gitiles/gitiles_repository.py
index 9d49da023fb1b42dfb78e7dc4f2db334005ddb61..59aa97bf89f0d90abb804961066302b71897231d 100644
--- a/appengine/findit/common/git_repository.py
+++ b/appengine/findit/lib/gitiles/gitiles_repository.py
@@ -8,15 +8,15 @@ from datetime import timedelta
import json
import re
-from common import diff
-from common.blame import Blame
-from common.blame import Region
-from common.cache_decorator import Cached
-from common.cache_decorator import CompressedMemCacher
-from common.change_log import ChangeLog
-from common.change_log import FileChangeInfo
-from common.repository import Repository
-
+# TODO(http://crbug.com/660466): We should try to break dependencies.
+from lib.cache_decorator import Cached
+from lib.cache_decorator import CompressedMemCacher
+from lib.gitiles import diff
+from lib.gitiles.blame import Blame
+from lib.gitiles.blame import Region
+from lib.gitiles.change_log import ChangeLog
+from lib.gitiles.change_log import FileChangeInfo
+from lib.gitiles.git_repository import GitRepository
COMMIT_POSITION_PATTERN = re.compile(
'^Cr-Commit-Position: refs/heads/master@{#(\d+)}$', re.IGNORECASE)
@@ -28,11 +28,11 @@ TIMEZONE_PATTERN = re.compile('[-+]\d{4}$')
CACHE_EXPIRE_TIME_SECONDS = 24 * 60 * 60
-class GitRepository(Repository):
- """Represents a git repository on https://chromium.googlesource.com."""
+class GitilesRepository(GitRepository):
+ """Use Gitiles to access a repository on https://chromium.googlesource.com."""
def __init__(self, repo_url=None, http_client=None):
- super(GitRepository, self).__init__()
+ super(GitilesRepository, self).__init__()
if repo_url and repo_url.endswith('/'):
self._repo_url = repo_url[:-1]
else:
« no previous file with comments | « appengine/findit/lib/gitiles/git_repository.py ('k') | appengine/findit/lib/gitiles/test/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698