Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: appengine/findit/crash/test/findit_for_chromecrash_test.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: reordering imports Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/crash_testcase.py ('k') | appengine/findit/crash/test/results_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/findit_for_chromecrash_test.py
diff --git a/appengine/findit/crash/test/findit_for_chromecrash_test.py b/appengine/findit/crash/test/findit_for_chromecrash_test.py
index 27b6711c74c21e4c80842b4273f558853074ba96..029e39860cdf8dec8eae7aa1b2fd04dc3ba5f217 100644
--- a/appengine/findit/crash/test/findit_for_chromecrash_test.py
+++ b/appengine/findit/crash/test/findit_for_chromecrash_test.py
@@ -3,7 +3,6 @@
# found in the LICENSE file.
from common import chrome_dependency_fetcher
-from common import git_repository
from common.dependency import DependencyRoll
from common.http_client_appengine import HttpClientAppengine
from crash import chromecrash_parser
@@ -25,6 +24,7 @@ from crash.stacktrace import Stacktrace
from crash.test.crash_pipeline_test import DummyCrashData
from crash.test.crash_testcase import CrashTestCase
from crash.type_enums import CrashClient
+from lib.gitiles import gitiles_repository
from model import analysis_status
from model.crash.crash_analysis import CrashAnalysis
from model.crash.fracas_crash_analysis import FracasCrashAnalysis
@@ -77,7 +77,7 @@ def _FinditForFracas():
class FinditForChromeCrashTest(CrashTestCase):
chrome_dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
- git_repository.GitRepository(http_client=HttpClientAppengine()))
+ gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
# TODO(wrengr): what was the purpose of this test? As written it's
# just testing that mocking works. I'm guessing it was to check that
@@ -98,7 +98,7 @@ class FinditForChromeCrashTest(CrashTestCase):
analysis.client_id = CrashClient.FRACAS
findit_client = _FinditForChromeCrash(
- git_repository.GitRepository(http_client=HttpClientAppengine()))
+ gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
result, tags = findit_client.FindCulprit(analysis).ToDicts()
# TODO(wrengr): just test for the NullCulprit directly; instead of
# going through |ToDicts|.
« no previous file with comments | « appengine/findit/crash/test/crash_testcase.py ('k') | appengine/findit/crash/test/results_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698