appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: reverted unintended change to an __init__ file Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/waterfall/test/build_failure_analysis_test.py ('K') | « appengine/findit/waterfall/test/extract_deps_info_pipeline_test.py ('k') | appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py » ('j') | appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

index eecb1c15c9ff0edc94b71127ca84402f00563f97..d508f527d54d3a5bb8082fbc1c3b4f816ece6b06 100644

--- a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

+++ b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

@@ -4,7 +4,7 @@

from testing_utils import testing

-from common.git_repository import GitRepository

+from lib.gitiles.gitiles_repository import GitilesRepository

stgao 2016/10/28 18:21:00 order of import

wrengr 2016/10/28 19:24:49 Done.

from common.waterfall import failure_type

from model import analysis_approach_type

from model import analysis_status

@@ -36,7 +36,7 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):

def setUp(self):

super(IdentifyTryJobCulpritPipelineTest, self).setUp()

- self.mock(GitRepository, 'GetChangeLog', self._MockGetChangeLog)

+ self.mock(GitilesRepository, 'GetChangeLog', self._MockGetChangeLog)

def testGetFailedRevisionFromResultsDict(self):

self.assertIsNone(