Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1678)

Unified Diff: appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: reverted unintended change to an __init__ file Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
diff --git a/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py b/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
index da107dd0f791d4ae1be44b3421850720f5c4cdc8..1125d8dcf97a7fe2c3a54f33b7d80b75fab84d52 100644
--- a/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
+++ b/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
@@ -8,8 +8,8 @@ import textwrap
from google.appengine.ext import ndb
+from lib.gitiles.gitiles_repository import GitilesRepository
stgao 2016/10/28 18:21:00 order of import
wrengr 2016/10/28 19:24:49 Done.
from common import time_util
-from common.git_repository import GitRepository
from common.http_client_appengine import HttpClientAppengine as HttpClient
from common.pipeline_wrapper import BasePipeline
from common.rietveld import Rietveld
@@ -92,7 +92,7 @@ def _GetCulpritInfo(repo_name, revision):
"""Returns commit position/time and code-review url of the given revision."""
# TODO(stgao): get repo url at runtime based on the given repo name.
# unused arg - pylint: disable=W0612,W0613
- repo = GitRepository(
+ repo = GitilesRepository(
'https://chromium.googlesource.com/chromium/src.git', HttpClient())
change_log = repo.GetChangeLog(revision)
return change_log.commit_position, change_log.code_review_url

Powered by Google App Engine
This is Rietveld 408576698