[Findit] Factoring the gitiles (etc) stuff out into its own directory

appengine/findit/waterfall/build_failure_analysis.py

Index: appengine/findit/waterfall/build_failure_analysis.py
diff --git a/appengine/findit/waterfall/build_failure_analysis.py b/appengine/findit/waterfall/build_failure_analysis.py
index 369d72f10ce74332b86c996b70a9db5e87d3c2a6..d489b91c4bcb8863527575f3379fb6ec52ebab68 100644
--- a/appengine/findit/waterfall/build_failure_analysis.py
+++ b/appengine/findit/waterfall/build_failure_analysis.py
@@ -6,8 +6,8 @@ from collections import defaultdict
 import os
 import re
 
-from common.diff import ChangeType
-from common.git_repository import GitRepository
+from lib.gitiles.diff import ChangeType
+from lib.gitiles.gitiles_repository import GitilesRepository

[stgao, 2016/10/28 18:21:00]

order of import

[wrengr, 2016/10/28 19:24:49]

Done.

 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from waterfall import waterfall_config
 from waterfall.failure_signal import FailureSignal
@@ -44,7 +44,7 @@ def _GetGitBlame(repo_info, touched_file_path):
   """
   if repo_info:
     repo_url = repo_info['repo_url']
-    git_repo = GitRepository(repo_url, HttpClient())
+    git_repo = GitilesRepository(repo_url, HttpClient())
     revision = repo_info['revision']
     return git_repo.GetBlame(touched_file_path, revision)
 
@@ -442,7 +442,7 @@ def _GetChangedLinesForDependencyRepo(roll, file_path_in_log, line_numbers):
     Tests if the same lines mentioned in failure log are changed within
     the DEPS roll, if so, return those line numbers.
   """
-  roll_repo = GitRepository(roll['repo_url'], HttpClient())
+  roll_repo = GitilesRepository(roll['repo_url'], HttpClient())
   old_revision = roll['old_revision']
   new_revision = roll['new_revision']
   old_change_log = roll_repo.GetChangeLog(old_revision)
@@ -805,4 +805,4 @@ def AnalyzeBuildFailure(
 
   suspected_cls = _ConvertCLFailureMapToList(cl_failure_map)
 
-  return analysis_result, suspected_cls
+  return analysis_result, suspected_cls