appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: rebase-update Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/gitiles/diff.py ('K') | « appengine/findit/waterfall/test/extract_deps_info_pipeline_test.py ('k') | appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

index 3a87c8d2ddd19dcbbf33ad553475d7c332464fd1..4404f8f6be2fc8cedffb16b1fa03bad518020b9b 100644

--- a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

+++ b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

@@ -4,7 +4,7 @@

from testing_utils import testing

-from common.git_repository import GitRepository

+from gitiles.git_repository import GitRepository

from common.waterfall import failure_type

from model import analysis_status

from model import result_status

@@ -1069,4 +1069,4 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):

master_name, builder_name, build_number, None,

heuristic_cls, compile_suspected_cl)

self.assertEqual(1, len(instances))

- self.assertTrue(instances[0].started)

+ self.assertTrue(instances[0].started)