Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: appengine/findit/gitiles/git_repository.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: rebase-update Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/gitiles/git_repository.py
diff --git a/appengine/findit/common/git_repository.py b/appengine/findit/gitiles/git_repository.py
similarity index 96%
rename from appengine/findit/common/git_repository.py
rename to appengine/findit/gitiles/git_repository.py
index 88e4308a741e4fbc1e2c2616fd2ceb68d7380db3..12f1babadd7a2e269be450aefbe537cfe01f8039 100644
--- a/appengine/findit/common/git_repository.py
+++ b/appengine/findit/gitiles/git_repository.py
@@ -8,15 +8,13 @@ from datetime import timedelta
import json
import re
-from common import diff
-from common.blame import Blame
-from common.blame import Region
-from common.cache_decorator import Cached
-from common.cache_decorator import CompressedMemCacher
-from common.change_log import ChangeLog
-from common.change_log import FileChangeInfo
-from common.repository import Repository
-
+from gitiles.blame import Blame, Region
+from gitiles.change_log import ChangeLog, FileChangeInfo
+from gitiles import diff
+# TODO(wrengr): can we remove this dependency on cache_decorator (and
+# hence on appengine) by pushing that off into a subclass defined outside
+# of the gitiles directory?
+from gitiles.cache_decorator import Cached, CompressedMemCacher
COMMIT_POSITION_PATTERN = re.compile(
'^Cr-Commit-Position: refs/heads/master@{#(\d+)}$', re.IGNORECASE)
@@ -28,11 +26,10 @@ TIMEZONE_PATTERN = re.compile('[-+]\d{4}$')
CACHE_EXPIRE_TIME_SECONDS = 24 * 60 * 60
-class GitRepository(Repository):
+class GitRepository(object):
"""Represents a git repository on https://chromium.googlesource.com."""
def __init__(self, repo_url, http_client):
- super(GitRepository, self).__init__()
self.repo_url = repo_url
if self.repo_url.endswith('/'):
self.repo_url = self.repo_url[:-1]

Powered by Google App Engine
This is Rietveld 408576698