appengine/findit/handlers/verify_analysis.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/handlers/verify_analysis.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: reordering imports Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « appengine/findit/handlers/try_job_result.py ('k') | appengine/findit/handlers/version.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from common.base_handler import BaseHandler	5 from common.base_handler import BaseHandler, Permission

6 from common.base_handler import Permission

7	6

8	7

9 class VerifyAnalysis(BaseHandler):	8 class VerifyAnalysis(BaseHandler):

10 PERMISSION_LEVEL = Permission.ANYONE	9 PERMISSION_LEVEL = Permission.ANYONE

11	10

12 def HandleGet(self): # pylint: disable=R0201	11 def HandleGet(self): # pylint: disable=R0201

13 """Checks for revert or fix of CLs in a failed build cycle.	12 """Checks for revert or fix of CLs in a failed build cycle.

14	13

15 Later it will be extended for coverage analysis.	14 Later it will be extended for coverage analysis.

16 This corresponds to the "Verify after green" button in the following page:	15 This corresponds to the "Verify after green" button in the following page:

17 https://1-dot-findit-for-me.appspot.com/list-build?count=400&type=triage	16 https://1-dot-findit-for-me.appspot.com/list-build?count=400&type=triage

18	17

19 This endpoint serves JSON result.	18 This endpoint serves JSON result.

20 """	19 """

21 return BaseHandler.CreateError('Not implemented yet!', 501)	20 return BaseHandler.CreateError('Not implemented yet!', 501)

OLD	NEW