appengine/findit/handlers/check_duplicate_failures.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/handlers/check_duplicate_failures.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: reordering imports Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from common.base_handler import BaseHandler	5 from common.base_handler import BaseHandler, Permission

6 from common.base_handler import Permission

7 from model.wf_analysis import WfAnalysis	6 from model.wf_analysis import WfAnalysis

8 from model import result_status	7 from model import result_status

9	8

10	9

11 def _GetFailedStepsForEachCL(analysis):	10 def _GetFailedStepsForEachCL(analysis):

12 """Gets suspected CLs and their corresponding failed steps."""	11 """Gets suspected CLs and their corresponding failed steps."""

13 suspected_cl_steps = {}	12 suspected_cl_steps = {}

14 if (analysis is None or analysis.result is None or	13 if (analysis is None or analysis.result is None or

15 not analysis.result['failures']):	14 not analysis.result['failures']):

16 return suspected_cl_steps	15 return suspected_cl_steps

(...skipping 133 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
150	149

151 def HandleGet(self):	150 def HandleGet(self):

152 """Checks the untriaged results and mark them as duplicates if they are."""	151 """Checks the untriaged results and mark them as duplicates if they are."""

153 analyses = _FetchAndSortUntriagedAnalyses()	152 analyses = _FetchAndSortUntriagedAnalyses()

154	153

155 for analysis in analyses:	154 for analysis in analyses:

156 _ModifyStatusIfDuplicate(analysis)	155 _ModifyStatusIfDuplicate(analysis)

157	156

158 def HandlePost(self): # pragma: no cover	157 def HandlePost(self): # pragma: no cover

159 return self.HandleGet()	158 return self.HandleGet()

OLD	NEW

« no previous file with comments | « appengine/findit/handlers/build_failure.py ('k') | appengine/findit/handlers/config.py » ('j') | no next file with comments »