[Findit] Factoring the gitiles (etc) stuff out into its own directory

appengine/findit/handlers/help_triage.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-from common.base_handler import BaseHandler
-from common.base_handler import Permission
-from common.git_repository import GitRepository
+from lib.gitiles.gitiles_repository import GitilesRepository

[stgao, 2016/10/28 18:21:00]

order of import.

[wrengr, 2016/10/28 19:24:48]

Done.

+from common.base_handler import BaseHandler, Permission
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
 from waterfall import build_util
 
 
 def _GetFirstFailedBuild(master_name, builder_name, build_number):
   """Checks failed_steps for current_build and finds the first failed build."""
   analysis = WfAnalysis.Get(master_name, builder_name, build_number)
   if not analysis or not analysis.result['failures']:
@@ skipping 13 matching lines @@
 
 
 def _AllFailedStepsPassed(passed_steps, current_failed_steps):
   for current_failed_step in current_failed_steps:
     if current_failed_step not in passed_steps:
       return False
   return True
 
 def GetPossibleRevertInfoFromRevision(revision):
   """Parse message to get information of reverting and reverted cls."""
-  git_repo = GitRepository('https://chromium.googlesource.com/chromium/src.git',
-                           HttpClient())
+  git_repo = GitilesRepository(
+      'https://chromium.googlesource.com/chromium/src.git', HttpClient())
   change_log = git_repo.GetChangeLog(revision)
   if not change_log:  # pragma: no cover
     return {}
 
   reverted_revision = change_log.reverted_revision
   if not reverted_revision:
     return {}
 
   reverted_cl_change_log = git_repo.GetChangeLog(reverted_revision)
 
@@ skipping 106 matching lines @@
     """
     url = self.request.get('url').strip()
     build_keys = buildbot.ParseBuildUrl(url)
 
     if not build_keys:  # pragma: no cover
       return {'data': {}}
 
     data = _CheckReverts(*build_keys)
 
     return {'data': data}