[Findit] Factoring the gitiles (etc) stuff out into its own directory

appengine/findit/crash/test/changelist_classifier_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 
-from common.blame import Blame
-from common.blame import Region
-from common.change_log import ChangeLog
 from common.dependency import Dependency
 from common.dependency import DependencyRoll
-from common.git_repository import GitRepository
 from common.http_client_appengine import HttpClientAppengine
 from common import chrome_dependency_fetcher
-from common import git_repository
 from crash.crash_report import CrashReport
 from crash import changelist_classifier
 from crash.results import MatchResult
 from crash.stacktrace import CallStack
 from crash.stacktrace import StackFrame
 from crash.stacktrace import Stacktrace
 from crash.test.crash_test_suite import CrashTestSuite
+from lib.gitiles.blame import Blame
+from lib.gitiles.blame import Region
+from lib.gitiles.change_log import ChangeLog
+from lib.gitiles.gitiles_repository import GitilesRepository
 
 DUMMY_CHANGELOG1 = ChangeLog.FromDict({
     'author_name': 'r@chromium.org',
     'message': 'dummy',
     'committer_email': 'r@chromium.org',
     'commit_position': 175900,
     'author_email': 'r@chromium.org',
     'touched_files': [
         {
             'change_type': 'add',
@@ skipping 102 matching lines @@
     }
 
     stack_deps = {
         'src/': Dependency('src/', 'https://url_src', 'rev1', 'DEPS'),
         'src/new': Dependency('src/new', 'https://new', 'rev2', 'DEPS'),
     }
 
     def _MockGetChangeLogs(*_):
       return [DUMMY_CHANGELOG1, DUMMY_CHANGELOG2, DUMMY_CHANGELOG3]
 
-    self.mock(git_repository.GitRepository, 'GetChangeLogs', _MockGetChangeLogs)
+    self.mock(GitilesRepository, 'GetChangeLogs', _MockGetChangeLogs)
 
     dep_file_to_changelogs, ignore_cls = (
         changelist_classifier.GetChangeLogsForFilesGroupedByDeps(
-            regression_deps_rolls, stack_deps, git_repository.GitRepository()))
+            regression_deps_rolls, stack_deps, GitilesRepository()))
     dep_file_to_changelogs_json = defaultdict(lambda: defaultdict(list))
     for dep, file_to_changelogs in dep_file_to_changelogs.iteritems():
       for file_path, changelogs in file_to_changelogs.iteritems():
         for changelog in changelogs:
           dep_file_to_changelogs_json[dep][file_path].append(changelog.ToDict())
 
     expected_dep_file_to_changelogs_json = {
         'src/': {
             'a.cc': [DUMMY_CHANGELOG1.ToDict()],
             'f.cc': [DUMMY_CHANGELOG3.ToDict()]
@@ skipping 71 matching lines @@
             ]
         }
     }
 
     dummy_blame = Blame('9', 'a.cc')
     dummy_blame.AddRegion(
         Region(1, 5, '6', 'a', 'a@chromium.org', 'Thu Mar 31 21:24:43 2016'))
     dummy_blame.AddRegion(
         Region(6, 10, '1', 'b', 'b@chromium.org', 'Thu Jun 19 12:11:40 2015'))
 
-    self.mock(GitRepository, 'GetBlame', lambda *_: dummy_blame)
+    self.mock(GitilesRepository, 'GetBlame', lambda *_: dummy_blame)
 
     stack_deps = {
         'src/': Dependency('src/', 'https://url_src', 'rev1', 'DEPS'),
     }
 
     expected_match_results = [{
         'url': 'https://repo.test/+/1',
         'review_url': 'https://codereview.chromium.org/3281',
         'revision': '1',
         'project_path': 'src/',
         'author': 'r@chromium.org',
         'time': 'Thu Mar 31 21:24:43 2016',
         'reasons': None,
         'confidence': None,
         'changed_files': None
     }]
 
     match_results = changelist_classifier.FindMatchResults(
         dep_file_to_changelogs, dep_file_to_stack_infos, stack_deps,
-        git_repository.GitRepository())
+        GitilesRepository())
     self.assertListEqual([result.ToDict() for result in match_results],
                          expected_match_results)
 
   # TODO(http://crbug.com/659346): why do these mocks give coverage
   # failures? That's almost surely hiding a bug in the tests themselves.
   def testFindItForCrashNoRegressionRange(self): # pragma: no cover
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict', lambda *_: {})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
     cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        git_repository.GitRepository())
+        GitilesRepository())
     # N.B., for this one test we really do want regression_range=None.
     report = DUMMY_REPORT._replace(regression_range=None)
     self.assertListEqual(cl_classifier(report), [])
 
   def testFindItForCrashNoMatchFound(self):
     self.mock(changelist_classifier, 'FindMatchResults', lambda *_: [])
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
     cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        git_repository.GitRepository())
+        GitilesRepository())
     self.assertListEqual(cl_classifier(DUMMY_REPORT), [])
 
   def testFindItForCrash(self):
 
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       frame1 = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1])
       frame2 = StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7])
       match_result1.file_to_stack_infos = {
           'a.cc': [(frame1, 0), (frame2, 0)]
@@ skipping 13 matching lines @@
 
       return [match_result1, match_result2]
 
     self.mock(changelist_classifier, 'FindMatchResults', _MockFindMatchResults)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
     cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        git_repository.GitRepository())
+        GitilesRepository())
     results = cl_classifier(DUMMY_REPORT)
     expected_match_results = [
         {
             'reasons': [('TopFrameIndex', 1.0, 'Top frame is #0'),
                         ('MinDistance', 1, 'Minimum distance is 0')],
             'changed_files': [{'info': 'Minimum distance (LOC) 0, frame #0',
                                'blame_url': None, 'file': 'a.cc'}],
             'time': 'Thu Mar 31 21:24:43 2016',
             'author': 'r@chromium.org',
             'url': 'https://repo.test/+/1',
@@ skipping 38 matching lines @@
       return [match_result1, match_result2, match_result3]
 
     self.mock(changelist_classifier, 'FindMatchResults', _MockFindMatchResults)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
 
     cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        git_repository.GitRepository())
+        GitilesRepository())
     results = cl_classifier(DUMMY_REPORT)
     expected_match_results = [
         {
             'author': 'r@chromium.org',
             'changed_files': [
                 {
                     'blame_url': None,
                     'file': 'a.cc',
                     'info': 'Minimum distance (LOC) 1, frame #0'
                 }
@@ skipping 38 matching lines @@
       return [match_result1, match_result2]
 
     self.mock(changelist_classifier, 'FindMatchResults', _MockFindMatchResults)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
 
     cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        git_repository.GitRepository())
+        GitilesRepository())
     self.assertListEqual(cl_classifier(DUMMY_REPORT), [])