appengine/findit/crash/test/callstack_test.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/crash/test/callstack_test.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: reverted unintended change to an __init__ file Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« appengine/findit/common/codereview.py ('K') | « appengine/findit/crash/scorers/test/scorer_test_suite.py ('k') | appengine/findit/crash/test/changelist_classifier_test.py » ('j') | appengine/findit/crash/test/crash_testcase.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from common.dependency import Dependency	5 from common.dependency import Dependency

6 from crash.callstack import StackFrame, CallStack	6 from crash.callstack import StackFrame, CallStack

7 from crash.test.stacktrace_test_suite import StacktraceTestSuite	7 from crash.test.stacktrace_test_suite import StacktraceTestSuite

8 from crash.type_enums import CallStackFormatType	8 from crash.type_enums import CallStackFormatType, CallStackLanguageType

9 from crash.type_enums import CallStackLanguageType

10	9

11	10

12 class CallStackTest(StacktraceTestSuite):	11 class CallStackTest(StacktraceTestSuite):

13	12

14 def testStackFrameToString(self):	13 def testStackFrameToString(self):

15 self.assertEqual(	14 self.assertEqual(

16 StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', []).ToString(),	15 StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', []).ToString(),

17 '#0 in func @ f.cc')	16 '#0 in func @ f.cc')

18 self.assertEqual(	17 self.assertEqual(

19 StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [1]).ToString(),	18 StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [1]).ToString(),

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90 def testParseLineForFracasJavaStack(self):	89 def testParseLineForFracasJavaStack(self):

91 stack = CallStack(0, CallStackFormatType.DEFAULT,	90 stack = CallStack(0, CallStackFormatType.DEFAULT,

92 CallStackLanguageType.JAVA)	91 CallStackLanguageType.JAVA)

93	92

94 stack.ParseLine('#0 0xxx in android.app.func app.java:2450', {})	93 stack.ParseLine('#0 0xxx in android.app.func app.java:2450', {})

95 self._VerifyTwoStackFramesEqual(	94 self._VerifyTwoStackFramesEqual(

96 stack[0],	95 stack[0],

97 StackFrame(	96 StackFrame(

98 0, '', 'android.app.func', 'android/app.java',	97 0, '', 'android.app.func', 'android/app.java',

99 'android/app.java', [2450]))	98 'android/app.java', [2450]))

OLD	NEW