appengine/findit/waterfall/pull_changelog_pipeline.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/waterfall/pull_changelog_pipeline.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: moving ./gitiles to ./lib/gitiles Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« appengine/findit/handlers/help_triage.py ('K') | « appengine/findit/waterfall/identify_try_job_culprit_pipeline.py ('k') | appengine/findit/waterfall/send_notification_for_culprit_pipeline.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from common.git_repository import GitRepository	5 from lib.gitiles.git_repository import GitRepository

6 from common.http_client_appengine import HttpClientAppengine as HttpClient	6 from common.http_client_appengine import HttpClientAppengine as HttpClient

7 from common.pipeline_wrapper import pipeline	7 from common.pipeline_wrapper import pipeline

8 from common.pipeline_wrapper import BasePipeline	8 from common.pipeline_wrapper import BasePipeline

9	9

10	10

11 class PullChangelogPipeline(BasePipeline):	11 class PullChangelogPipeline(BasePipeline):

12 """A pipeline to pull change log of CLs."""	12 """A pipeline to pull change log of CLs."""

13	13

14 # TODO: for files in dependencies(blink, v8, skia, etc), use blame first.	14 # TODO: for files in dependencies(blink, v8, skia, etc), use blame first.

15 GIT_REPO = GitRepository(	15 GIT_REPO = GitRepository(

(...skipping 19 matching lines...) Expand all Loading...
35	35

36 for build in failure_info.get('builds', {}).values():	36 for build in failure_info.get('builds', {}).values():

37 for revision in build['blame_list']:	37 for revision in build['blame_list']:

38 change_log = self.GIT_REPO.GetChangeLog(revision)	38 change_log = self.GIT_REPO.GetChangeLog(revision)

39 if not change_log: # pragma: no cover	39 if not change_log: # pragma: no cover

40 raise pipeline.Retry('Failed to get change log for %s' % revision)	40 raise pipeline.Retry('Failed to get change log for %s' % revision)

41	41

42 change_logs[revision] = change_log.ToDict()	42 change_logs[revision] = change_log.ToDict()

43	43

44 return change_logs	44 return change_logs

OLD	NEW