Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: appengine/findit/handlers/help_triage.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)
Patch Set: moving ./gitiles to ./lib/gitiles Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from common.base_handler import BaseHandler 5 from lib.gitiles.git_repository import GitRepository
stgao 2016/10/17 17:31:43 style nit:order of imports. You may want to check
6 from common.base_handler import Permission 6 from common.base_handler import BaseHandler, Permission
7 from common.git_repository import GitRepository
8 from common.http_client_appengine import HttpClientAppengine as HttpClient 7 from common.http_client_appengine import HttpClientAppengine as HttpClient
9 from model.wf_analysis import WfAnalysis 8 from model.wf_analysis import WfAnalysis
10 from waterfall import buildbot 9 from waterfall import buildbot
11 from waterfall import build_util 10 from waterfall import build_util
12 11
13 12
14 def _GetFirstFailedBuild(master_name, builder_name, build_number): 13 def _GetFirstFailedBuild(master_name, builder_name, build_number):
15 """Checks failed_steps for current_build and finds the first failed build.""" 14 """Checks failed_steps for current_build and finds the first failed build."""
16 analysis = WfAnalysis.Get(master_name, builder_name, build_number) 15 analysis = WfAnalysis.Get(master_name, builder_name, build_number)
17 if not analysis or not analysis.result['failures']: 16 if not analysis or not analysis.result['failures']:
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 """ 158 """
160 url = self.request.get('url').strip() 159 url = self.request.get('url').strip()
161 build_keys = buildbot.ParseBuildUrl(url) 160 build_keys = buildbot.ParseBuildUrl(url)
162 161
163 if not build_keys: # pragma: no cover 162 if not build_keys: # pragma: no cover
164 return {'data': {}} 163 return {'data': {}}
165 164
166 data = _CheckReverts(*build_keys) 165 data = _CheckReverts(*build_keys)
167 166
168 return {'data': data} 167 return {'data': data}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698