appengine/findit/gitiles/__init__.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/gitiles/init.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: rebase-update Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.
stgao 2016/10/13 05:47:32 As we discussed in the meeting regarding new code As we discussed in the meeting regarding new code layout, gitiles won't be in the root dir. Would you mind make it in appengine/findit/common/gitiles/ for now? wrengr 2016/10/14 18:33:14 I thought it was going to be called ./lib/gitiles? Show quoted text On 2016/10/13 05:47:32, stgao wrote: > As we discussed in the meeting regarding new code layout, gitiles won't be in > the root dir. > Would you mind make it in appengine/findit/common/gitiles/ for now? I thought it was going to be called ./lib/gitiles? If that's where it'll live eventually I don't see any reason to put it in ./common/gitiles for now stgao 2016/10/17 17:31:43 sg. But it should be ./libs instead ./lib as discu Show quoted text On 2016/10/14 18:33:14, wrengr wrote: > On 2016/10/13 05:47:32, stgao wrote: > > As we discussed in the meeting regarding new code layout, gitiles won't be in > > the root dir. > > Would you mind make it in appengine/findit/common/gitiles/ for now? > > I thought it was going to be called ./lib/gitiles? If that's where it'll live > eventually I don't see any reason to put it in ./common/gitiles for now sg. But it should be ./libs instead ./lib as discussed :)
2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

OLD	NEW

« appengine/findit/common/rietveld.py ('K') | « appengine/findit/crash/test/results_test.py ('k') | appengine/findit/gitiles/blame.py » ('j') | no next file with comments »

Side by Side Diff: appengine/findit/gitiles/__init__.py

Side by Side Diff: appengine/findit/gitiles/init.py