[Findit] Factoring the gitiles (etc) stuff out into its own directory

appengine/findit/common/rietveld.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+# TODO(wrengr): this file is only used by waterfall. We should either

[stgao, 2016/10/13 05:47:32]

This should go to an infra/ directory in the new code layout.

[wrengr, 2016/10/27 17:28:00]

Is there a bug ticket for doing the new layout? If so, this todo should be added
there. I'll adjust the version in the file as appropriate.

+# move it to that directory, or else factor out the dependency on
+# HttpClientAppengine by abstracting over the HTTP_CLIENT member. The

[stgao, 2016/10/13 05:47:32]

Regarding the HTTP_CLIENT member, we could pass it over as a parameter in the
constructor.

[wrengr, 2016/10/27 17:28:00]

Acknowledged.

+# only thing we use/need HTTP_CLIENT for is to call the Post method,
+# which could just as well be rewritten to use the __call__ method
+# instead; hence, we could just pass an appropriate callable object to
+# the constructor (incidentally allowing multiple Rietveld objects to
+# share the same HTTP_CLIENT, if desired) rather than allocating our own
+# one automatically. Does rietveld itself actually require appengine?
+# Or is that just an incidental circumstance about our particular use
+# of it?
 import logging
 import re
 import urlparse
 
-from common.codereview import CodeReview

[stgao, 2016/10/13 05:47:32]

Please check my previous comment on why we wanted to keep the interface
CodeReview.

 from common.http_client_appengine import HttpClientAppengine
 
 
 _RIETVELD_ISSUE_NUMBER_RE = re.compile('^/(\d+)/?.*')
 
 
-class Rietveld(CodeReview):
+class Rietveld(object):
   """The implementation of CodeReview interface for Rietveld."""
   HTTP_CLIENT = HttpClientAppengine(follow_redirects=False)
 
   def _GetXsrfToken(self, rietveld_url):
     """Returns the xsrf token for follow-up requests."""
     headers = {
         'X-Requesting-XSRF-Token': '1',
         'Accept': 'text/plain',
     }
     url = '%s/xsrf_token' % rietveld_url
@@ skipping 50 matching lines @@
         'no_redirect': 'True',
     }
     content_type, body = self._EncodeMultipartFormData(form_fields)
     headers = {
         'Content-Type': content_type,
         'Accept': 'text/plain',
     }
     status_code, content = self.HTTP_CLIENT.Post(
         url, data=body, headers=headers)
     return status_code == 200 and content == 'OK'