appengine/findit/common/codereview.py - Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/common/codereview.py

Issue 2344443005: [Findit] Factoring the gitiles (etc) stuff out into its own directory (Closed)

Patch Set: rebase-update Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.

4

5

6 # pylint: disable=E0711, W0613, R0201

7 class CodeReview(object): # pragma: no cover
stgao 2016/10/13 05:47:31 Please check my previous comment on why we want to Please check my previous comment on why we want to keep this interface.
8 """An interface to interact with code review."""

9

10 def PostMessage(self, codereview_url, message):

11 """ Posts the given message to the CL codereview of the specified url.

12

13 args:

14 codereview_url(str): The url to a CL codereview.

15 message(str): The message to be posted to the codereview.

16 """

17 raise NotImplemented()

OLD	NEW