Issue 234443002: Remove enable-software-compositing command-line flag.

Issue 234443002: Remove enable-software-compositing command-line flag. (Closed)

Created:
6 years, 8 months ago by jbauman

Modified:
6 years, 8 months ago

Reviewers:
piman, jochen (gone - plz use gerrit), enne (OOO)

CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove enable-software-compositing command-line flag. It should be enabled by default everywhere. BUG=350141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264159

Patch Set 4 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -51 lines)			Patch
M	content/browser/gpu/gpu_data_manager_impl_private.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl_private.cc	View	1 2 3	5 chunks	+6 lines, -36 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/public/test/browser_test_base.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/browser/webkit_test_controller.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

the command line switch is used by the virtual/softwarecompositing layout test suite. if that's not ...

6 years, 8 months ago (2014-04-11 20:21:53 UTC) #2

piman

+enne re: layout tests https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode744 content/browser/gpu/gpu_data_manager_impl_private.cc:744: prefs->accelerated_compositing_enabled = false; There's no ...

6 years, 8 months ago (2014-04-11 20:30:46 UTC) #3

jbauman

On 2014/04/11 20:30:46, piman wrote: > +enne re: layout tests > > https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_data_manager_impl_private.cc > File ...

6 years, 8 months ago (2014-04-14 18:32:35 UTC) #4

On 2014/04/11 20:30:46, piman wrote:
> +enne re: layout tests
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> File content/browser/gpu/gpu_data_manager_impl_private.cc (right):
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:744:
> prefs->accelerated_compositing_enabled = false;
> There's no early out in this function, so this is overridden below. Just
remove?
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:765:
> prefs->accelerated_compositing_for_animation_enabled = false;
> This too
> (also, does that mean we can completely remove gpu::GPU_FEATURE_TYPE_3D_CSS
and
> related blacklist entries if any?)
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:768:
> prefs->accelerated_compositing_for_video_enabled = false;
> This too
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:776:
> prefs->force_compositing_mode = true;
> I'm lost between all the overrides... LayoutTests still need FCM to be off
> (though smart people are working on fixing that). Does that mean they still
have
> a way to override this?
> 
Yeah, that's overridden by WebKitTestController::OverrideWebkitPrefs.

>
https://codereview.chromium.org/234443002/diff/20001/content/shell/browser/we...
> File content/shell/browser/webkit_test_controller.cc (left):
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/shell/browser/we...
> content/shell/browser/webkit_test_controller.cc:332:
> prefs->accelerated_2d_canvas_enabled = true;
> I'm not sure that's right... this is used for layout tests, which have a
> different set of flags that's set by default. It sounds like this would
disable
> accelerated canvas layout tests altogether?
> 
> IIRC that's where the virtual/softwarecompositing "virtual" test suite comes
in.
> See third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
> 
> Maybe this can be keyed off --disable-gpu instead (which seems to be set as
well
> in that virtual test suite)?

That might be a good idea.

jbauman

PTAL. These issues should be fixed. On 2014/04/11 20:30:46, piman wrote: > +enne re: layout ...

6 years, 8 months ago (2014-04-15 22:22:16 UTC) #5

PTAL. These issues should be fixed.

On 2014/04/11 20:30:46, piman wrote:
> +enne re: layout tests
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> File content/browser/gpu/gpu_data_manager_impl_private.cc (right):
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:744:
> prefs->accelerated_compositing_enabled = false;
> There's no early out in this function, so this is overridden below. Just
remove?
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:765:
> prefs->accelerated_compositing_for_animation_enabled = false;
> This too
> (also, does that mean we can completely remove gpu::GPU_FEATURE_TYPE_3D_CSS
and
> related blacklist entries if any?)

Yeah, eventually I want to remove most of these entries, but they're used in a
few other places and I want to keep this patch a bit more self-contained.
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:768:
> prefs->accelerated_compositing_for_video_enabled = false;
> This too
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/browser/gpu/gpu_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:776:
> prefs->force_compositing_mode = true;
> I'm lost between all the overrides... LayoutTests still need FCM to be off
> (though smart people are working on fixing that). Does that mean they still
have
> a way to override this?
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/shell/browser/we...
> File content/shell/browser/webkit_test_controller.cc (left):
> 
>
https://codereview.chromium.org/234443002/diff/20001/content/shell/browser/we...
> content/shell/browser/webkit_test_controller.cc:332:
> prefs->accelerated_2d_canvas_enabled = true;
> I'm not sure that's right... this is used for layout tests, which have a
> different set of flags that's set by default. It sounds like this would
disable
> accelerated canvas layout tests altogether?
> 
> IIRC that's where the virtual/softwarecompositing "virtual" test suite comes
in.
> See third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
> 
> Maybe this can be keyed off --disable-gpu instead (which seems to be set as
well
> in that virtual test suite)?

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/234443002/60001

6 years, 8 months ago (2014-04-15 22:40:56 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/234443002/60001

6 years, 8 months ago (2014-04-16 01:30:13 UTC) #9

Message was sent while issue was closed.

Change committed as 264159

Expand Messages | Collapse Messages