Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2344413002: Correct function names in log messages in HTMLMediaElement.cpp (Closed)

Created:
4 years, 3 months ago by Srirama
Modified:
4 years, 3 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct function names in log messages in HTMLMediaElement.cpp Committed: https://crrev.com/b2712b58ae6639c7113544fbb05ea9b4d4eb544f Cr-Commit-Position: refs/heads/master@{#419435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Srirama
PTAL. Found this while debugging one of the test case using log messages.
4 years, 3 months ago (2016-09-17 12:37:13 UTC) #3
fs
lgtm
4 years, 3 months ago (2016-09-17 16:20:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344413002/1
4 years, 3 months ago (2016-09-19 04:12:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/295275)
4 years, 3 months ago (2016-09-19 07:40:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344413002/1
4 years, 3 months ago (2016-09-19 11:18:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 12:27:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 12:29:03 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b2712b58ae6639c7113544fbb05ea9b4d4eb544f
Cr-Commit-Position: refs/heads/master@{#419435}

Powered by Google App Engine
This is Rietveld 408576698