Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 23444082: css rendering bug : fixed-position-element and 'left' (Closed)

Created:
7 years, 3 months ago by a.suchit
Modified:
7 years, 3 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

css rendering bug : fixed-position-element and 'left' Fixed position element was rendered as normal flow irrespective of it's relative-position-parents. if fixed position element does not have left and/or right position then it should render as normal flow with respect to it's parent. So fixed position element is shifted with the value of relative position of it's parent. R=eseidel@chromium.org BUG=31286 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158089

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/css-properties-position-relative-as-parent-fixed.html View 1 chunk +158 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/css/css-properties-position-relative-as-parent-fixed-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/fast/css/css-properties-position-relative-as-parent-fixed-expected.txt View 1 chunk +208 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 3 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
suchit.agrawal
7 years, 3 months ago (2013-09-18 12:23:08 UTC) #1
eseidel
The new behavior matches FF/IE, correct?
7 years, 3 months ago (2013-09-19 15:17:20 UTC) #2
a.suchit
On 2013/09/19 15:17:20, eseidel wrote: > The new behavior matches FF/IE, correct? IT is matching ...
7 years, 3 months ago (2013-09-19 16:46:44 UTC) #3
eseidel
lgtm
7 years, 3 months ago (2013-09-19 16:53:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.suchit@samsung.com/23444082/9001
7 years, 3 months ago (2013-09-19 16:54:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=6447
7 years, 3 months ago (2013-09-19 19:25:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.suchit@samsung.com/23444082/26001
7 years, 3 months ago (2013-09-20 05:20:01 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 07:42:07 UTC) #8
Message was sent while issue was closed.
Change committed as 158089

Powered by Google App Engine
This is Rietveld 408576698