Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 23444080: Implement KeyboardEvent.repeat attribute (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 2 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, garykac, Wez
Visibility:
Public.

Description

Implement KeyboardEvent.repeat attribute Implement KeyboardEvent.repeat attribute as per the DOM level 3 specification: https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#widl-KeyboardEvent-repeat This attribute is already implemented in IE10 and is currently being worked on for Firefox. BUG=263724 TEST=fast/events/constructors/keyboard-event-constructor.html TEST=fast/events/keyboardevent-repeat.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158868

Patch Set 1 #

Patch Set 2 : Add layout test #

Patch Set 3 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -23 lines) Patch
M LayoutTests/fast/events/constructors/keyboard-event-constructor.html View 2 chunks +14 lines, -12 lines 0 comments Download
M LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt View 2 chunks +14 lines, -10 lines 0 comments Download
A LayoutTests/fast/events/keyboardevent-repeat.html View 1 1 chunk +40 lines, -0 lines 0 comments Download
A + LayoutTests/fast/events/keyboardevent-repeat-expected.txt View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/events/KeyboardEvent.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/events/KeyboardEvent.cpp View 1 2 4 chunks +5 lines, -0 lines 0 comments Download
M Source/core/events/KeyboardEvent.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/testing/runner/EventSender.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-18 07:43:55 UTC) #1
haraken
LGTM. Needs an approval from an API owner.
7 years, 3 months ago (2013-09-18 07:52:46 UTC) #2
tkent
not lgtm. In this implementation, 'repeat' IDL attribute doesn't represent actual key repeat state.
7 years, 3 months ago (2013-09-18 22:19:44 UTC) #3
do-not-use
On 2013/09/18 22:19:44, tkent wrote: > not lgtm. > In this implementation, 'repeat' IDL attribute ...
7 years, 3 months ago (2013-09-19 06:15:04 UTC) #4
tkent
On 2013/09/19 06:15:04, Christophe Dumez wrote: > On 2013/09/18 22:19:44, tkent wrote: > > not ...
7 years, 3 months ago (2013-09-19 06:35:01 UTC) #5
do-not-use
On 2013/09/19 06:35:01, tkent wrote: > On 2013/09/19 06:15:04, Christophe Dumez wrote: > > On ...
7 years, 3 months ago (2013-09-20 13:05:17 UTC) #6
tkent
On 2013/09/20 13:05:17, Christophe Dumez (OOO) wrote: > To implement this, I would have to ...
7 years, 3 months ago (2013-09-20 14:11:05 UTC) #7
do-not-use
On 2013/09/20 14:11:05, tkent wrote: > On 2013/09/20 13:05:17, Christophe Dumez (OOO) wrote: > > ...
7 years, 3 months ago (2013-09-20 14:14:25 UTC) #8
do-not-use
On 2013/09/20 14:14:25, Christophe Dumez (OOO) wrote: > On 2013/09/20 14:11:05, tkent wrote: > > ...
7 years, 3 months ago (2013-09-20 14:30:29 UTC) #9
tkent
lgtm. I verified this feature was approved to ship in blink-dev. Let's verify the feature ...
7 years, 2 months ago (2013-09-24 22:40:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23444080/12001
7 years, 2 months ago (2013-09-24 23:54:57 UTC) #11
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/KeyboardEvent.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 2 months ago (2013-09-24 23:55:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23444080/19001
7 years, 2 months ago (2013-10-03 18:14:55 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 02:22:08 UTC) #14
Message was sent while issue was closed.
Change committed as 158868

Powered by Google App Engine
This is Rietveld 408576698