Fix stuck state when long press on a button is performed.

Fix stuck state when long press on a button is performed.

This makes sure that when a tap becomes a long press, we keep
SHOW_PRESSED_STATE until either it becomes a LONG_TAP (finger is lifted),
or SCROLL, or window focus is lost (a context menu has been opened). At
which point we will send SHOW_PRESS_CANCEL.

BUG=285712
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223283

[boliu, 2013-09-13 23:25:19]

+joth for aw owners

Tested this on webview and the button pressed after long press bug is fixed.

[Ted C, 2013-09-13 23:50:25]

lgtm w/ nits

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1684:
public void onWindowFocusChanged(boolean hasWindowFocus) {
I would add:

/**
 * @see View#onWindowFocusChanged(boolean)
 */

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1686:
mContentViewGestureHandler.onWindowFocusLost();
+2 indent

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java
(right):

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:869:
if (mLongPressDetector.isInLongPress() && mLastLongPressEvent != null) {
+2 indent for the conditional

https://codereview.chromium.org/23444068/diff/1/content/public/android/javate...
File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java
(right):

https://codereview.chromium.org/23444068/diff/1/content/public/android/javate...
content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java:693:
mockDelegate.mGestureTypeList.get(1));
I would do .intValue() on the get(1) instead of creating a new Integer.

[Maria, 2013-09-14 01:09:34]

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1684:
public void onWindowFocusChanged(boolean hasWindowFocus) {
On 2013/09/13 23:50:26, Ted C wrote:
> I would add:
> 
> /**
>  * @see View#onWindowFocusChanged(boolean)
>  */

Done.

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1686:
mContentViewGestureHandler.onWindowFocusLost();
On 2013/09/13 23:50:26, Ted C wrote:
> +2 indent

Done.

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java
(right):

https://codereview.chromium.org/23444068/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:869:
if (mLongPressDetector.isInLongPress() && mLastLongPressEvent != null) {
On 2013/09/13 23:50:26, Ted C wrote:
> +2 indent for the conditional

Done.

[joth, 2013-09-14 07:51:51]

lgtm

https://codereview.chromium.org/23444068/diff/7001/android_webview/java/src/o...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(left):

https://codereview.chromium.org/23444068/diff/7001/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/AwContents.java:1489: //
If adding any code here, remember to adding correct handling in
receivePopupContents().
woot I only added this comment a week ago :-)
(complete with grammar mistakes)

that worked out nicely, thank you!

[commit-bot: I haz the power, 2013-09-14 18:35:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/23444068/7001

[commit-bot: I haz the power, 2013-09-15 00:12:50]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-09-15 01:34:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/23444068/7001

[commit-bot: I haz the power, 2013-09-15 15:13:12]

Change committed as 223283