Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: sdk/lib/io/file_impl.dart

Issue 23444037: dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Documentation edits. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/file_impl.dart
diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart
index d803c950ef4b72bcf0cb9d38f67162253194afbc..7969efbd4abb75f209f6575bd9f4467f71331a30 100644
--- a/sdk/lib/io/file_impl.dart
+++ b/sdk/lib/io/file_impl.dart
@@ -204,7 +204,7 @@ const int _CREATE_REQUEST = 1;
const int _DELETE_REQUEST = 2;
const int _RENAME_REQUEST = 3;
const int _OPEN_REQUEST = 4;
-const int _FULL_PATH_REQUEST = 5;
+const int _RESOLVE_SYMBOLIC_LINKS_REQUEST = 5;
const int _CLOSE_REQUEST = 6;
const int _POSITION_REQUEST = 7;
const int _SET_POSITION_REQUEST = 8;
@@ -444,28 +444,9 @@ class _File extends FileSystemEntity implements File {
return new _RandomAccessFile(id, "");
}
- Future<String> fullPath() {
- _ensureFileService();
- List request = new List(2);
- request[0] = _FULL_PATH_REQUEST;
- request[1] = path;
- return _fileService.call(request).then((response) {
- if (_isErrorResponse(response)) {
- throw _exceptionFromResponse(response,
- "Cannot retrieve full path",
- path);
- }
- return response;
- });
- }
+ Future<String> fullPath() => resolveSymbolicLinks();
- external static _fullPath(String path);
-
- String fullPathSync() {
- var result = _fullPath(path);
- throwIfError(result, "Cannot retrieve full path", path);
- return result;
- }
+ String fullPathSync() => resolveSymbolicLinksSync();
Stream<List<int>> openRead([int start, int end]) {
return new _FileStream(path, start, end);

Powered by Google App Engine
This is Rietveld 408576698