dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks.

sdk/lib/io/file_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 // Read the file in blocks of size 64k.
 const int _BLOCK_SIZE = 64 * 1024;
 
 
@@ skipping 186 matching lines @@
     return _openFuture.then((openedFile) => openedFile.close());
   }
 }
 
 
 const int _EXISTS_REQUEST = 0;
 const int _CREATE_REQUEST = 1;
 const int _DELETE_REQUEST = 2;
 const int _RENAME_REQUEST = 3;
 const int _OPEN_REQUEST = 4;
-const int _FULL_PATH_REQUEST = 5;
+const int _RESOLVE_SYMBOLIC_LINKS_REQUEST = 5;
 const int _CLOSE_REQUEST = 6;
 const int _POSITION_REQUEST = 7;
 const int _SET_POSITION_REQUEST = 8;
 const int _TRUNCATE_REQUEST = 9;
 const int _LENGTH_REQUEST = 10;
 const int _LENGTH_FROM_PATH_REQUEST = 11;
 const int _LAST_MODIFIED_REQUEST = 12;
 const int _FLUSH_REQUEST = 13;
 const int _READ_BYTE_REQUEST = 14;
 const int _WRITE_BYTE_REQUEST = 15;
@@ skipping 219 matching lines @@
   external static int _openStdio(int fd);
 
   static RandomAccessFile _openStdioSync(int fd) {
     var id = _openStdio(fd);
     if (id == 0) {
       throw new FileException("Cannot open stdio file for: $fd");
     }
     return new _RandomAccessFile(id, "");
   }
 
-  Future<String> fullPath() {
+  Future<String> resolveSymbolicLinks() {
     _ensureFileService();
     List request = new List(2);
-    request[0] = _FULL_PATH_REQUEST;
+    request[0] = _RESOLVE_SYMBOLIC_LINKS_REQUEST;
     request[1] = path;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
-                                     "Cannot retrieve full path",
+                                     "Cannot resolve symbolic links",
                                      path);
       }
       return response;
     });
   }
 
-  external static _fullPath(String path);
+  Future<String> fullPath() => resolveSymbolicLinks();

[Anders Johnsen, 2013/09/09 12:24:48]

This looks odd. Deprecate fullPath?

[Søren Gjesse, 2013/09/11 07:21:01]

We should set a deadline for when fullPath is removed.

[Bill Hesse, 2013/09/13 06:34:13]

Deprecated, with deadline added.

 
-  String fullPathSync() {
-    var result = _fullPath(path);
-    throwIfError(result, "Cannot retrieve full path", path);
+  external static _resolveSymbolicLinks(String path);
+
+  String resolveSymbolicLinksSync() {
+    var result = _resolveSymbolicLinks(path);
+    throwIfError(result, "Cannot resolve symbolic links", path);
     return result;
   }
 
+  String fullPathSync() => resolveSymbolicLinksSync();
+
   Stream<List<int>> openRead([int start, int end]) {
     return new _FileStream(path, start, end);
   }
 
   IOSink openWrite({FileMode mode: FileMode.WRITE,
                     Encoding encoding: UTF8}) {
     if (mode != FileMode.WRITE &&
         mode != FileMode.APPEND) {
       throw new ArgumentError(
           "Wrong FileMode. Use FileMode.WRITE or FileMode.APPEND");
@@ skipping 503 matching lines @@
   void _checkNotClosed() {
     if (closed) {
       throw new FileException("File closed", path);
     }
   }
 
   Future _closedException() {
     return new Future.error(new FileException("File closed", path));
   }
 }