dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks.

runtime/bin/directory.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include "bin/dartutils.h"
+#include "bin/file.h"
 #include "bin/thread.h"
 #include "include/dart_api.h"
 #include "platform/assert.h"
 
 
 namespace dart {
 namespace bin {
 
 // Forward declaration.
 static void DirectoryService(Dart_Port, Dart_Port, Dart_CObject*);
@@ skipping 266 matching lines @@
     CObjectString path(request[1]);
     CObjectString new_path(request[2]);
     bool completed = Directory::Rename(path.CString(), new_path.CString());
     if (completed) return CObject::True();
     return CObject::NewOSError();
   }
   return CObject::IllegalArgumentError();
 }
 
 
+static CObject* DirectoryResolveSymbolicLinksRequest(

[Anders Johnsen, 2013/09/09 12:24:48]

Why don't we use the file.cc version for all paths?

[Bill Hesse, 2013/09/13 06:34:13]

Done.

+    const CObjectArray& request) {
+  if (request.Length() == 2 && request[1]->IsString()) {
+    CObjectString filename(request[1]);
+    char* result = File::GetCanonicalPath(filename.CString());
+    if (result != NULL) {
+      CObject* path = new CObjectString(CObject::NewString(result));
+      free(result);
+      return path;
+    } else {
+      return CObject::NewOSError();
+    }
+  }
+  return CObject::IllegalArgumentError();
+}
+
+
 static void DirectoryService(Dart_Port dest_port_id,
                              Dart_Port reply_port_id,
                              Dart_CObject* message) {
   CObject* response = CObject::IllegalArgumentError();
   CObjectArray request(message);
   if (message->type == Dart_CObject_kArray) {
     if (request.Length() > 1 && request[0]->IsInt32()) {
       CObjectInt32 requestType(request[0]);
       switch (requestType.Value()) {
         case Directory::kCreateRequest:
@@ skipping 13 matching lines @@
           break;
         case Directory::kListNextRequest:
           response = DirectoryListNextRequest(request);
           break;
         case Directory::kListStopRequest:
           response = DirectoryListStopRequest(request);
           break;
         case Directory::kRenameRequest:
           response = DirectoryRenameRequest(request, reply_port_id);
           break;
+        case Directory::kResolveSymbolicLinksRequest:
+          response = DirectoryResolveSymbolicLinksRequest(request);
+          break;
         default:
           UNREACHABLE();
       }
     }
   }
 
   Dart_PostCObject(reply_port_id, response->AsApiCObject());
 }
 
 
@@ skipping 130 matching lines @@
   if (listing->error()) {
     listing->HandleError("Invalid path");
     listing->HandleDone();
   } else {
     while (ListNext(listing)) {}
   }
 }
 
 }  // namespace bin
 }  // namespace dart