Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 23444033: MIPS: Improve TruncateNumberToI implementation after DoubleToIStub usage (r16461). (Closed)

Created:
7 years, 3 months ago by kilvadyb
Modified:
7 years, 3 months ago
CC:
v8-dev
Base URL:
git@github.com:paul99/v8m-rb.git@master
Visibility:
Public.

Description

MIPS: Improve TruncateNumberToI implementation after DoubleToIStub usage (r16461). Using TruncateHeapNumberToI here simplifies the code and we get rid of ConvertToInt32 and EmitOutOfInt32RangeTruncate macro assembler instructions. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -193 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +76 lines, -11 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 3 chunks +1 line, -25 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +4 lines, -157 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 3 months ago (2013-09-02 20:27:20 UTC) #1
rmcilroy_google
lgtm
7 years, 3 months ago (2013-09-03 10:34:13 UTC) #2
palfia
7 years, 3 months ago (2013-09-03 11:42:17 UTC) #3
Committed as r16505.

Powered by Google App Engine
This is Rietveld 408576698