third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString.html - Issue 2344403002: Convert LayoutTests/svg/dom/SVGLengthList*.html js-tests.js to testharness.js based tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString.html

Issue 2344403002: Convert LayoutTests/svg/dom/SVGLengthList*.html js-tests.js to testharness.js based tests (Closed)

Patch Set: Align with review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-replaceItem.html ('K') | « third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-replaceItem-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString.html

diff --git a/third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString.html b/third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString.html

index f808d36638bbc14aed1ec5da6b44011a10e999b1..78f579bbb1a146d1cb820801029351b2613c4567 100644

--- a/third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString.html

+++ b/third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-setEmptyString.html

@@ -1,20 +1,22 @@

<!DOCTYPE HTML>

-<svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">

+<title>SVGLengthList, set empty string</title>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<svg width="200" height="200">

</svg>

-<script src="../../resources/js-test.js"></script>

-if (window.testRunner)

- testRunner.dumpAsText();

+test(function() {

+ var text = document.querySelector('text');

+ var list = text.x.baseVal;

+ text.setAttribute("x", "1 2 3");

+ assert_equals(list.numberOfItems, 3);

+ text.setAttribute("x", "");

+ assert_equals(list.numberOfItems, 0);

-var text = document.querySelector('text');

-text.setAttribute("x", "1 2 3");

-shouldBe("text.x.baseVal.numberOfItems", "3");

-text.setAttribute("x", "");

-shouldBe("text.x.baseVal.numberOfItems", "0");

-text.setAttribute("x", "1 2 3");

-shouldBe("text.x.baseVal.numberOfItems", "3");

-text.removeAttribute("x");

-shouldBe("text.x.baseVal.numberOfItems", "0");

-</script>

+ text.setAttribute("x", "1 2 3");

+ assert_equals(list.numberOfItems, 3);

+ text.removeAttribute("x");

+ assert_equals(list.numberOfItems, 0);

+});

+</script>