Add OptimizedCodeList and DeoptimizedCodeList to native contexts. Both lists are weak. This makes i…

src/compiler.cc

Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 6c2bdce26f9a2540adf5a66484d51103afc91628..24099a97464202b01314dee9be7e92e7023d61fc 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -877,9 +877,13 @@ static void InstallCodeCommon(CompilationInfo* info) {
 
 static void InsertCodeIntoOptimizedCodeMap(CompilationInfo* info) {
   Handle<Code> code = info->code();
-  if (FLAG_cache_optimized_code &&
-      info->osr_ast_id().IsNone() &&
-      code->kind() == Code::OPTIMIZED_FUNCTION) {
+  if (code->kind() != Code::OPTIMIZED_FUNCTION) return;  // Nothing to do.
+
+  // The native context has a weak list of all optimized code.
+  info->context()->native_context()->AddOptimizedCode(*code);

[Michael Starzinger, 2013/09/03 21:52:31]

This is a bad choking point to add code to the weak list for two reasons:
1) The name of this function implies that it only deals with the optimized code
map, and nothing else.
2) One of the two call-sites (i.e. Compiler::InstallOptimizedCode) actually only
calls it if there is not yet another optimized code object for the same native
context in the optimize code map.

Can we hoist this out to the two call-sites and leave this method untouched?

[titzer, 2013/09/04 11:19:04]

I've moved it out to the point that the optimized code is transferred into the
CompilationInfo.

+
+  // Cache non-OSR optimized code.
+  if (FLAG_cache_optimized_code && info->osr_ast_id().IsNone()) {
     Handle<JSFunction> function = info->closure();
     Handle<SharedFunctionInfo> shared(function->shared());
     Handle<FixedArray> literals(function->literals());